Re: [PATCH 3/7] cpufreq: Contain scaling_cur_freq.attr in cpufreq_attrs

[Rafael J. Wysocki]

On Mon, Jun 23, 2025 at 3:34 PM Lifeng Zheng <zhenglifeng1@xxxxxxxxxx> wrote:
>
> After commit c034b02e213d ("cpufreq: expose scaling_cur_freq sysfs file for
> set_policy() drivers"), the file scaling_cur_freq is exposed to all
> drivers. No need to create this file separately. It's better to be
> contained in cpufreq_attrs.

Fair enough.

> Signed-off-by: Lifeng Zheng <zhenglifeng1@xxxxxxxxxx>
> ---
>  drivers/cpufreq/cpufreq.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index efc1f4ac85cb..2303890de0ba 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -967,6 +967,7 @@ static struct attribute *cpufreq_attrs[] = {
>         &cpuinfo_min_freq.attr,
>         &cpuinfo_max_freq.attr,
>         &cpuinfo_transition_latency.attr,
> +       &scaling_cur_freq.attr,
>         &scaling_min_freq.attr,
>         &scaling_max_freq.attr,
>         &affected_cpus.attr,
> @@ -1095,10 +1096,6 @@ static int cpufreq_add_dev_interface(struct cpufreq_policy *policy)
>                         return ret;
>         }
>
> -       ret = sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr);
> -       if (ret)
> -               return ret;
> -
>         if (cpufreq_driver->bios_limit) {
>                 ret = sysfs_create_file(&policy->kobj, &bios_limit.attr);
>                 if (ret)
> --
> 2.33.0
>