Re: [PATCH v6 6/9] arm64: dts: freescale: move aliases from imx91_93_common.dtsi to board dts

[Frank Li]

On Mon, Jun 23, 2025 at 05:57:29PM +0800, Joy Zou wrote:
> These aliases aren't common and need to drop in imx91_93_common.dtsi.
> The part aliases are moved from imx91_93_common.dtsi to imx91-11x11-evk.dts
> and imx93-11x11-evk.dts for the convenience of customers.
>
> Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
> ---
> Changes in v6:
> 1. add new modification for aliases change.
> ---
>  .../boot/dts/freescale/imx91-11x11-evk.dts    | 13 +++++++
>  .../boot/dts/freescale/imx91_93_common.dtsi   | 34 -------------------
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 19 +++++++++++

There are 10 imx93 boards at upstream kernel.

Krzysztof Kozlowski:

	In https://lore.kernel.org/imx/4e8f2426-92a1-4c7e-b860-0e10e8dd886c@xxxxxxxxxx/
You provide comments about "no common aliases".

	Consider there are 10 imx93 boards. Do you think it is worth to
move it to 10 boards' dts file?

Frank

>  3 files changed, 32 insertions(+), 34 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts
> index 0acd97ed14da..52b3f57ba347 100644
> --- a/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx91-11x11-evk.dts
> @@ -15,7 +15,20 @@ / {
>  	aliases {
>  		ethernet0 = &fec;
>  		ethernet1 = &eqos;
> +		gpio0 = &gpio1;
> +		gpio1 = &gpio2;
> +		gpio2 = &gpio3;
> +		i2c0 = &lpi2c1;
> +		i2c1 = &lpi2c2;
> +		i2c2 = &lpi2c3;
> +		mmc0 = &usdhc1;
> +		mmc1 = &usdhc2;
>  		rtc0 = &bbnsm_rtc;
> +		serial0 = &lpuart1;
> +		serial1 = &lpuart2;
> +		serial2 = &lpuart3;
> +		serial3 = &lpuart4;
> +		serial4 = &lpuart5;
>  	};
>
>  	chosen {
> diff --git a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> index 2a2ed0266c1e..7c8c68151b14 100644
> --- a/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx91_93_common.dtsi
> @@ -18,40 +18,6 @@ / {
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>
> -	aliases {
> -		gpio0 = &gpio1;
> -		gpio1 = &gpio2;
> -		gpio2 = &gpio3;
> -		gpio3 = &gpio4;
> -		i2c0 = &lpi2c1;
> -		i2c1 = &lpi2c2;
> -		i2c2 = &lpi2c3;
> -		i2c3 = &lpi2c4;
> -		i2c4 = &lpi2c5;
> -		i2c5 = &lpi2c6;
> -		i2c6 = &lpi2c7;
> -		i2c7 = &lpi2c8;
> -		mmc0 = &usdhc1;
> -		mmc1 = &usdhc2;
> -		mmc2 = &usdhc3;
> -		serial0 = &lpuart1;
> -		serial1 = &lpuart2;
> -		serial2 = &lpuart3;
> -		serial3 = &lpuart4;
> -		serial4 = &lpuart5;
> -		serial5 = &lpuart6;
> -		serial6 = &lpuart7;
> -		serial7 = &lpuart8;
> -		spi0 = &lpspi1;
> -		spi1 = &lpspi2;
> -		spi2 = &lpspi3;
> -		spi3 = &lpspi4;
> -		spi4 = &lpspi5;
> -		spi5 = &lpspi6;
> -		spi6 = &lpspi7;
> -		spi7 = &lpspi8;
> -	};
> -
>  	cpus: cpus {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 8491eb53120e..674b2be900e6 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -12,6 +12,25 @@ / {
>  	model = "NXP i.MX93 11X11 EVK board";
>  	compatible = "fsl,imx93-11x11-evk", "fsl,imx93";
>
> +	aliases {
> +		ethernet0 = &fec;
> +		ethernet1 = &eqos;
> +		gpio0 = &gpio1;
> +		gpio1 = &gpio2;
> +		gpio2 = &gpio3;
> +		i2c0 = &lpi2c1;
> +		i2c1 = &lpi2c2;
> +		i2c2 = &lpi2c3;
> +		mmc0 = &usdhc1;
> +		mmc1 = &usdhc2;
> +		rtc0 = &bbnsm_rtc;
> +		serial0 = &lpuart1;
> +		serial1 = &lpuart2;
> +		serial2 = &lpuart3;
> +		serial3 = &lpuart4;
> +		serial4 = &lpuart5;
> +	};
> +
>  	chosen {
>  		stdout-path = &lpuart1;
>  	};
> --
> 2.37.1
>