Re: [PATCH] poll: rust: allow poll_table ptrs to be null

[Benno Lossin]

On Mon Jun 23, 2025 at 1:56 PM CEST, Christian Brauner wrote:
> On Fri, 20 Jun 2025 11:49:35 +0000, Alice Ryhl wrote:
>> It's possible for a poll_table to be null. This can happen if an
>> end-user just wants to know if a resource has events right now without
>> registering a waiter for when events become available. Furthermore,
>> these null pointers should be handled transparently by the API, so we
>> should not change `from_ptr` to return an `Option`. Thus, change
>> `PollTable` to wrap a raw pointer rather than use a reference so that
>> you can pass null.
>> 
>> [...]
>
> Applied to the vfs-6.17.rust branch of the vfs/vfs.git tree.
> Patches in the vfs-6.17.rust branch should appear in linux-next soon.
>
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
>
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
>
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs-6.17.rust
>
> [1/1] poll: rust: allow poll_table ptrs to be null
>       https://git.kernel.org/vfs/vfs/c/6efbf978891b

You took my RB without changing the safety comment that I had a concern
about. Can we fix that before you send the pull request?

---
Cheers,
Benno