Re: [PATCH 5/5] KVM: arm64: gic-v5: Probe for GICv5
From: Sascha Bischoff
Date: Mon Jun 23 2025 - 09:14:28 EST
On Fri, 2025-06-20 at 13:25 -0700, Oliver Upton wrote:
> On Fri, Jun 20, 2025 at 04:07:52PM +0000, Sascha Bischoff wrote:
> > +/**
> > + * vgic_v5_probe - probe for a VGICv5 compatible interrupt
> > controller
> > + * @info: pointer to the GIC description
> > + *
> > + * Returns 0 if the VGICv5 has been probed successfully, returns
> > an error code
> > + * otherwise.
> > + */
>
> nit: avoid kerneldoc style
>
> This actually generates documentation as well as build warnings when
> we
> screw up the format. I'd only do this sort of thing for sufficiently
> public functions.
>
> Thanks,
> Oliver
Done. Have made this into a non-kernel-doc comment.
FWIW, this was mimicking what is done for vgic_v3_probe.
Thanks,
Sascha
>