[PATCH v6 22/24] thermal/drivers/imx: convert to use devm_request*_irq_probe()
From: Pan Chuang
Date: Mon Jun 23 2025 - 08:48:14 EST
From: Yangtao Li <frank.li@xxxxxxxx>
The new devm_request_*irq_probe API prints an error message by default
when the request fails, and consumers can provide custom error messages.
Converting drivers to use this API has the following benefits:
1.More than 2,000 lines of code can be saved by removing redundant error
messages in drivers.
2.Upper-layer functions can directly return error codes without missing
debugging information.
3.Having proper and consistent information about why the device cannot
be used is useful.
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Cc: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/thermal/imx_thermal.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index bab52e6b3b15..151976d0820e 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -729,13 +729,12 @@ static int imx_thermal_probe(struct platform_device *pdev)
if (ret)
goto thermal_zone_unregister;
- ret = devm_request_threaded_irq(dev, data->irq,
- imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread,
- 0, "imx_thermal", data);
- if (ret < 0) {
- dev_err(dev, "failed to request alarm irq: %d\n", ret);
+ ret = devm_request_threaded_irq_probe(dev, data->irq,
+ imx_thermal_alarm_irq,
+ imx_thermal_alarm_irq_thread,
+ 0, "imx_thermal", data, "alarm");
+ if (ret < 0)
goto thermal_zone_unregister;
- }
pm_runtime_put(data->dev);
--
2.39.0