[PATCH v6 24/24] thermal/drivers/airoha: convert to use devm_request*_irq_probe()
From: Pan Chuang
Date: Mon Jun 23 2025 - 08:46:53 EST
The new devm_request_*irq_probe API prints an error message by default
when the request fails, and consumers can provide custom error messages.
Converting drivers to use this API has the following benefits:
1.More than 2,000 lines of code can be saved by removing redundant error
messages in drivers.
2.Upper-layer functions can directly return error codes without missing
debugging information.
3.Having proper and consistent information about why the device cannot
be used is useful.
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Cc: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/thermal/airoha_thermal.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c
index b9fd6bfc88e5..6918043c8630 100644
--- a/drivers/thermal/airoha_thermal.c
+++ b/drivers/thermal/airoha_thermal.c
@@ -441,13 +441,11 @@ static int airoha_thermal_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
- ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
- airoha_thermal_irq, IRQF_ONESHOT,
- pdev->name, priv);
- if (ret) {
- dev_err(dev, "Can't get interrupt working.\n");
+ ret = devm_request_threaded_irq_probe(&pdev->dev, irq, NULL,
+ airoha_thermal_irq, IRQF_ONESHOT,
+ pdev->name, priv, NULL);
+ if (ret)
return ret;
- }
airoha_thermal_setup_monitor(priv);
airoha_thermal_setup_adc_val(dev, priv);
--
2.39.0