[PATCH v6 12/24] thermal/drivers/hisi: convert to use devm_request*_irq_probe()

From: Pan Chuang
Date: Mon Jun 23 2025 - 08:42:19 EST


From: Yangtao Li <frank.li@xxxxxxxx>

The new devm_request_*irq_probe API prints an error message by default
when the request fails, and consumers can provide custom error messages.

Converting drivers to use this API has the following benefits:

1.More than 2,000 lines of code can be saved by removing redundant error
messages in drivers.

2.Upper-layer functions can directly return error codes without missing
debugging information.

3.Having proper and consistent information about why the device cannot
be used is useful.

Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Cc: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/thermal/hisi_thermal.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index 4307161533a7..bf283b8c216b 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -574,14 +574,12 @@ static int hisi_thermal_probe(struct platform_device *pdev)
if (ret < 0)
return ret;

- ret = devm_request_threaded_irq(dev, ret, NULL,
- hisi_thermal_alarm_irq_thread,
- IRQF_ONESHOT, sensor->irq_name,
- sensor);
- if (ret < 0) {
- dev_err(dev, "Failed to request alarm irq: %d\n", ret);
+ ret = devm_request_threaded_irq_probe(dev, ret, NULL,
+ hisi_thermal_alarm_irq_thread,
+ IRQF_ONESHOT, sensor->irq_name,
+ sensor, "alarm");
+ if (ret < 0)
return ret;
- }

ret = data->ops->enable_sensor(sensor);
if (ret) {
--
2.39.0