Re: [PATCH v1 0/2] firmware: Add MediaTek TinySYS SCMI Protocol

[Cristian Marussi]

On Mon, Jun 23, 2025 at 02:01:34PM +0200, AngeloGioacchino Del Regno wrote:
> This series adds basic support for the MediaTek TinySYS SCMI Protocol,
> found on the MediaTek Dimensity 9200, 9300 and 9400, other than on the
> MT8196 Chromebook SoC.
> 
> This is used to communicate with the CM_MGR and other MCUs for power
> management purposes.

Hi Angelo,

thanks for this.

I will do a proper review in the coming days of this series anyway, but
upfront for future V2:

- you should provide some sort of documentation for this new
  vendor protocol and its messages, as an example from IMX:

	drivers/firmware/arm_scmi/vendors/imx/imx95.rst

- where is the SCMI driver that will call all the new vendor ops
  defined in: scmi_mtk_protocol.h ?

Thanks,
Cristian