Re: [PATCH v2 1/2] dmaengine: virt-dma: convert tasklet to BH workqueue for callback invocation
From: Andy Shevchenko
Date: Mon Jun 23 2025 - 06:45:35 EST
On Mon, Jun 16, 2025 at 12:48:03PM +0000, Alexander Kochetkov wrote:
> Currently DMA callbacks are called from tasklet. However the tasklet is
> marked deprecated and must be replaced by BH workqueue. Tasklet callbacks
> are executed either in the Soft IRQ context or from ksoftirqd thread. BH
> workqueue work items are executed in the BH context. Changing tasklet to
> BH workqueue improved DMA callback latencies.
>
> The commit changes virt-dma driver and all of its users:
> - tasklet is replaced to work_struct, tasklet callback updated accordingly
> - kill_tasklet() is replaced to cancel_work_sync()
> - added include of linux/interrupt.h where necessary
...
> drivers/dma/hsu/hsu.c | 2 +-
> drivers/dma/idma64.c | 3 ++-
Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
for the above two.
--
With Best Regards,
Andy Shevchenko