Re: [PATCH] arm64: dts: qcom: sc8180x: Add video clock controller node

[Krzysztof Kozlowski]

On 23/06/2025 12:01, Konrad Dybcio wrote:
> On 6/23/25 10:44 AM, Krzysztof Kozlowski wrote:
>> On 23/06/2025 10:14, Satya Priya Kakitapalli wrote:
>>> Add device node for video clock controller on Qualcomm
>>> SC8180X platform.
>>>
>>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
>>> ---
>>> Add device node for video clock controller on Qualcomm
>>> SC8180X platform.
>>> ---
>>>  arch/arm64/boot/dts/qcom/sc8180x.dtsi | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> index b74ce3175d209b569e634073662307964158b340..4590c2ff68a9885d8047d728bbf2dea0236d5b8f 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
>>> @@ -10,6 +10,7 @@
>>>  #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
>>>  #include <dt-bindings/clock/qcom,rpmh.h>
>>>  #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
>>> +#include <dt-bindings/clock/qcom,videocc-sm8150.h>
>>>  #include <dt-bindings/interconnect/qcom,icc.h>
>>>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>>  #include <dt-bindings/interconnect/qcom,sc8180x.h>
>>> @@ -2943,6 +2944,19 @@ usb_sec_dwc3_ss: endpoint {
>>>  			};
>>>  		};
>>>  
>>> +		videocc: clock-controller@ab00000 {
>> Why are you adding the same multiple times? This was added A YEAR AGO,
>> so you clearly send us some complete outdated ancient tree!
> 
> It seems like you're confusing something, there is no videocc node in
> sc8180x.dtsi


Heh, I am... the line below:
	compatible = "qcom,sm8150-videocc";
confused me and I looked at wrong file.

Satya:
Still for obvious reasons: NAK. See writing bindings or internal guideline.

Best regards,
Krzysztof