Re: [PATCH v6 13/23] ACPI: property: Refactor acpi_fwnode_get_reference_args()

From: Rafael J. Wysocki
Date: Mon Jun 23 2025 - 06:20:27 EST


On Mon, Jun 23, 2025 at 11:08 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Wed, Jun 18, 2025 at 05:43:48PM +0530, Anup Patel wrote:
> >
> > Currently acpi_fwnode_get_reference_args() calls the public function
> > __acpi_node_get_property_reference() which ignores the nargs_prop
> > parameter. To fix this, make __acpi_node_get_property_reference() to
> > call the static acpi_fwnode_get_reference() so that callers of
> > fwnode_get_reference_args() can still pass a valid property name to
> > fetch the number of arguments.
>
> Looks okay to me, but I think it's better to have more eyes here (Mika,
> Rafael?).

It would help if this were CCed to linux-acpi, but yeah.