Re: [PATCH v4 0/4] Describe the cameras in the PinePhone Pro dts

[Heiko Stuebner]

Hi,

Am Montag, 23. Juni 2025, 08:47:44 Mitteleuropäische Sommerzeit schrieb Sakari Ailus:
> Hi Olivier,
> 
> On Fri, Jun 20, 2025 at 05:21:31PM +0200, Olivier Benjamin wrote:
> > This series adds support for the Pine64 PinePhone Pro's rear and front
> > cameras in Device Tree.
> > This is based on some of Ondrej Jirman's patches hosted in his tree at
> > https://codeberg.org/megi/linux, but I have also fully reviewed and
> > re-written the code from the RK3399 datasheet, the PinePhone Pro
> > schematic, and the IMX258-0AQH5 software reference manual.
> > 
> > I have tested these changes on my PinePhone Pro and am able to take
> > photos from both cameras using libcamera's cam.
> > 
> > This series has raised a question about the proper label name for the
> > front/user camera and rear/world camera for phones.
> > This series is using "ucam" and "wcam", which is used in a few other
> > Rockship DTBs:
> >  - arch/arm64/boot/dts/rockchip/px30-evb.dts
> >  - rk3399-gru-scarlet.dtsi
> > 
> > Signed-off-by: Olivier Benjamin <olivier.benjamin@xxxxxxxxxxx>
> 
> Thanks for the patches.
> 
> I've picked the first two in the set, presumably the rest will be merged
> via another tree?

correct, and with the first two being applied, I can now also safely pick
the other two :-)

Thanks a lot
Heiko