Re: [PATCH] crypto: ccree - Don't use %pK through printk
From: Herbert Xu
Date: Mon Jun 23 2025 - 05:26:11 EST
On Wed, Jun 18, 2025 at 09:10:18AM +0200, Thomas Weißschuh wrote:
> In the past %pK was preferable to %p as it would not leak raw pointer
> values into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
> the regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk(). They can still unintentionally leak raw pointers or
> acquire sleeping locks in atomic contexts.
>
> Switch to the regular pointer formatting which is safer and
> easier to reason about.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---
> drivers/crypto/ccree/cc_buffer_mgr.c | 54 ++++++++++++++++++------------------
> drivers/crypto/ccree/cc_cipher.c | 4 +--
> drivers/crypto/ccree/cc_hash.c | 30 ++++++++++----------
> 3 files changed, 44 insertions(+), 44 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt