Re: [PATCH 4/5] serial: 8250: document doubled "type == PORT_8250_CIR" check
From: Andy Shevchenko
Date: Mon Jun 23 2025 - 04:20:17 EST
On Mon, Jun 23, 2025 at 10:46 AM Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> wrote:
>
> The check for "port.type == PORT_8250_CIR" is present twice in
> serial8250_register_8250_port(). The latter was already tried to be
> dropped by 1104321a7b3b ("serial: Delete dead code for CIR serial
> ports") and then reverted by 9527b82ae3af ("Revert "serial: Delete dead
> code for CIR serial ports"").
>
> Document this weirdness with a reason.
Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko