Re: [PATCH v4 2/2] nfsd: Implement large extent array support in pNFS

[Christoph Hellwig]

On Sat, Jun 21, 2025 at 07:52:45PM +0300, Sergey Bashirov wrote:
> +	memcpy(&rqstp->rq_arg, &lcp->lc_up_layout, sizeof(struct xdr_buf));

Nit: using a struct assignment like:

	rqstp->rq_arg = lcp->lc_up_layout;

might be a tad bettet due to type safety here.

> +	memcpy(&rqstp->rq_arg, &lcp->lc_up_layout, sizeof(struct xdr_buf));

Same here.

Otherwise this looks good to me (but I'm not the best reviwer for XDR
code :)):

Reviewed-by: Christoph Hellwig <hch@xxxxxx>