Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

From: Vlastimil Babka
Date: Mon Jun 23 2025 - 03:24:24 EST


On 6/22/25 21:02, Shivank Garg wrote:
>
> Hi Andrew,
>
> Thank you for addressing this.
>
> If you don’t mind me asking,
> I was curious why we used EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL here.
> I had previously received feedback recommending the use of EXPORT_SYMBOL_GPL
> to better align with the kernel’s licensing philosophy, which made sense to me.

That's the recommendation for new symbols, but this has become effectively a
rename (plus a new parameter) so it's a bit different situation.

> Thanks,
> Shivank
>