Re: [PATCH] gpiolib-sysfs: fix use-after-free in error path

From: Bartosz Golaszewski
Date: Mon Jun 23 2025 - 03:16:45 EST


From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>


On Mon, 23 Jun 2025 00:02:21 +0200, Antonio Quartulli wrote:
> When invoking device_create_with_groups() its return
> value is stored in `data->cdev_base`.
> However, in case of faiure, `data` is first
> freed and then derefernced in order to return
> `data->cdev_base`.
>
> Fix the use-after-free by extracting the error
> code before free'ing `data`.
>
> [...]

Thanks for the catch. I tweaked the commit message and added the Fixes: tag.
Applied, thanks!

[1/1] gpiolib-sysfs: fix use-after-free in error path
https://git.kernel.org/brgl/linux/c/e6bb78570f7d531622ec572ef9ddbe6e66ff16ce

Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>