Re: [PATCH v10] dma-engine: sun4i: Simplify error handling in probe()

From: Csókás Bence
Date: Mon Jun 23 2025 - 02:59:24 EST



On 2025. 06. 10. 9:53, Bence Csókás wrote:
Clean up error handling by using devm functions and dev_err_probe(). This
should make it easier to add new code, as we can eliminate the "goto
ladder" in sun4i_dma_probe().

Suggested-by: Chen-Yu Tsai <wens@xxxxxxxxxx>
Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>
Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>
Signed-off-by: Bence Csókás <csokas.bence@xxxxxxxxx>
---

Vinod, is there a problem with this patch? I'd love to hear your thoughts, because it has been practically unchanged since March, and only minor changes since the first submission last December. I can keep rebasing it ad nauseum every time you push to dma/next, but I think we both have a better use of our time. So, if you see anything that should prevent this from being merged, please tell me.

Thanks,
Bence