Re: EXTERNAL - [PATCH v2 3/4] arm64: dts: freescale: Add Mettler-Toledo Snowflake V2 support

[Wojciech Dubowik]

On Fri, Jun 20, 2025 at 11:23:43AM +0200, Krzysztof Kozlowski wrote:
> On 20/06/2025 10:41, Wojciech Dubowik wrote:
> > +
> > +	ili2511: ili2511@41 {
> 
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
I will rename it to touchscreen.
> 
> > +		compatible = "ilitek,ili251x";
> > +		reg = <0x41>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_touch>;
> > +		interrupt-parent = <&gpio1>;
> > +		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> > +		reset-gpios = <&gpio3 16 GPIO_ACTIVE_LOW>;
> > +	};
> > +
> > +	lvds: lvds@2c {
> > +		compatible = "ti,sn65dsi83";
> > +		reg = <0x2c>;
> > +		vcc-supply = <&reg_sn65dsi83_1v8>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_sn65dsi83>;
> > +		status = "okay";
> 
> Was it disabled anywhere?
Nope. I will remove the line.
> 
> > +		ports {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			port@0 {
> > +				reg = <0>;
> > +				bridge_in: endpoint {
> > +					remote-endpoint = <&mipi_dsi_out>;
> > +					data-lanes = <1 2>;
> > +				};
> > +			};
> > +
> > +			port@2 {
> > +				reg = <2>;
> > +				bridge_out: endpoint {
> > +					remote-endpoint = <&panel_in>;
> > +					data-lanes = <4 3 2 1>;
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	usbc-cc-controller@61 {
> > +		compatible = "ti,tusb320";
> > +		reg = <0x61>;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_usbc_controller>;
> > +		interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_LOW>;
> > +	};
> > +};
> > +
> > +&mipi_dsi {
> > +	status = "okay";
> > +	vddio-supply = <&reg_sn65dsi83_1v8>;
> > +	assigned-clocks = <&clk IMX8MM_CLK_DSI_CORE>,
> > +			  <&clk IMX8MM_VIDEO_PLL1_OUT>,
> > +			  <&clk IMX8MM_CLK_DSI_PHY_REF>;
> > +	assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_266M>,
> > +			  <&clk IMX8MM_VIDEO_PLL1_BYPASS>,
> > +			  <&clk IMX8MM_CLK_24M>;
> > +	assigned-clock-rates = <266000000>, <594000000>, <12000000>;
> > +	samsung,pll-clock-frequency = <12000000>;
> > +	samsung,burst-clock-frequency = <891000000>;
> > +	samsung,esc-clock-frequency = <54000000>;
> > +};
> > +
> > +&mipi_dsi_out {
> > +	remote-endpoint = <&bridge_in>;
> > +};
> > +
> > +&lcdif {
> > +	status = "okay";
> > +};
> > +
> > +&gpu_2d {
> > +	status = "okay";
> > +};
> > +
> > +&gpu_3d {
> > +	status = "okay";
> > +};
> > +
> > +&ecspi1 {
> > +	status = "disabled";
> > +};
> > +
> > +&gpio1 {
> > +	bootph-pre-ram;
> > +};
> > +
> > +&gpio2 {
> > +	bootph-pre-ram;
> > +};
> > +
> > +&gpio3 {
> > +	bootph-pre-ram;
> > +};
> > +
> > +&gpio4 {
> > +	bootph-pre-ram;
> > +};
> > +
> > +&gpio5 {
> > +	bootph-pre-ram;
> > +	status_led_controller_oe: status-led-controller-hog {
> > +		gpio-hog;
> > +		gpios = <4 GPIO_ACTIVE_HIGH>;
> > +		output-low;
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_hog_status_led_controller>;
> > +	};
> > +};
> > +
> > +&pca9450 {
> > +	bootph-pre-ram;
> > +};
> > +
> > +&{/soc@0/bus@30800000/i2c@30a20000/pmic@25/regulators} {
> 
> There is no label to override it? Probably should be added.
This could be merged with previous entry.
> 
> 
> > +	bootph-pre-ram;
> > +};
> > +
> 
> 
> 
> 
> > +&usbotg2 {
> > +	#address-cells = <1>;
> > +	#size-cells = <0>;
> > +	disable-over-current;
> > +	dr_mode = "host";
> > +	status = "okay";
> > +
> > +	usb1@1 {
> 
> usb@
> 
> Why usb1?
Copy and paste from other Kontron device tree. I will rename it to usb@.
> 
> > +		reg = <1>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		usbnet: ethernet@1 {
> > +			compatible = "usb424,9500";
> > +			reg = <1>;
> > +			mac-address = [ 00 00 00 00 00 00 ];
> > +		};
> > +	};
> > +};
> 
> 
> 
> Best regards,
> Krzysztof