Re: [PATCH] cpufreq: armada-8k: make both cpu masks static
From: Viresh Kumar
Date: Mon Jun 23 2025 - 01:23:46 EST
On 20-06-25, 13:14, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> An earlier patch marked one of the two CPU masks as 'static' to reduce stack
> usage, but if CONFIG_NR_CPUS is large enough, the function still produces
> a warning for compile testing:
>
> drivers/cpufreq/armada-8k-cpufreq.c: In function 'armada_8k_cpufreq_init':
> drivers/cpufreq/armada-8k-cpufreq.c:203:1: error: the frame size of 1416 bytes is larger than 1408 bytes [-Werror=frame-larger-than=]
>
> Normally this should be done using alloc_cpumask_var(), but since the
> driver already has a static mask and the probe function is not called
> concurrently, use the same trick for both.
>
> Fixes: 1ffec650d07f ("cpufreq: armada-8k: Avoid excessive stack usage")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/cpufreq/armada-8k-cpufreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied. Thanks.
--
viresh