Re: [PATCH net-next 3/3] net: hibmcge: configure FIFO thresholds according to the MAC controller documentation

[Jijie Shao]

on 2025/6/21 23:35, Jakub Kicinski wrote:
> On Thu, 19 Jun 2025 22:44:23 +0800 Jijie Shao wrote:
> > +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_FULL_M, full);
> > +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M	, empty);
> > +	}
> > +
> > +	if (dir & HBG_DIR_RX) {
> > +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_FULL_M, full);
> > +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M	, empty);
> nit checkpatch says:
>
> WARNING: line length of 81 exceeds 80 columns
> #62: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:306:
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M	, empty);
>
> ERROR: space prohibited before that ',' (ctx:WxW)
> #62: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:306:
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_TX_EMPTY_M	, empty);
>   		                                                      	^
>
> WARNING: line length of 81 exceeds 80 columns
> #67: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:311:
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M	, empty);
>
> ERROR: space prohibited before that ',' (ctx:WxW)
> #67: FILE: drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c:311:
> +		value |= FIELD_PREP(HBG_REG_CFG_FIFO_THRSLD_RX_EMPTY_M	, empty);
>   		                                                      	^
>
> total: 2 errors, 2 warnings, 0 checks, 79 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>        mechanically convert to the typical style using --fix or --fix-inplace.

This is my mistake.
Thanks for the guidance.

Thanks
Jijie Shao