Re: [Patch v4 09/13] perf/x86/intel: Setup PEBS data configuration and enable legacy groups

[Mi, Dapeng]

On 6/21/2025 5:36 PM, Peter Zijlstra wrote:
> On Fri, Jun 20, 2025 at 10:39:05AM +0000, Dapeng Mi wrote:
>> +static inline void __intel_update_large_pebs_flags(struct pmu *pmu)
>> +{
>> +	u64 caps = hybrid(pmu, arch_pebs_cap).caps;
>> +
>> +	x86_pmu.large_pebs_flags |= PERF_SAMPLE_TIME;
>> +	if (caps & ARCH_PEBS_LBR)
>> +		x86_pmu.large_pebs_flags |= PERF_SAMPLE_BRANCH_STACK;
>> +
>> +	if (!(caps & ARCH_PEBS_AUX))
>> +		x86_pmu.large_pebs_flags &= ~PERF_SAMPLE_DATA_SRC;
>> +	if (!(caps & ARCH_PEBS_GPR))
>> +		x86_pmu.large_pebs_flags &=
>> +			~(PERF_SAMPLE_REGS_INTR | PERF_SAMPLE_REGS_USER);
> Coding style wants { } on this, because multi-line.

Sure. Thanks.


>
>> +}