Re: [PATCH v3 14/15] docs: conf.py: several coding style fixes
From: Mauro Carvalho Chehab
Date: Sun Jun 22 2025 - 17:41:21 EST
Em Sun, 22 Jun 2025 14:55:26 -0600
Jonathan Corbet <corbet@xxxxxxx> escreveu:
> Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> writes:
>
> > conf.py is missing a SPDX header and doesn't really have
> > a proper python coding style. It also has an obsolete
> > commented LaTeX syntax that doesn't work anymore.
> >
> > Clean it up a little bit with some help from autolints
> > and manual adjustments.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > ---
> > Documentation/conf.py | 351 +++++++++++++++++++++---------------------
> > 1 file changed, 172 insertions(+), 179 deletions(-)
>
> This file is definitely getting out of hand...:)
Yes. I almost removed all commented code to make it a little more
palatable.
> I notice a lot of the changes are just from 'single quotes' to "double
> quotes". That adds a lot of churn; is there a reason for it?
Those churns are from black/autopep8, which also addressed other
coding style issues(*).
I don't mind much about using either single or double quote, but
having a standard is a good thing. At the plus side, as C uses
double quotes for strings this is closer to the kernel coding style.
So, I opted to merge such changes from the lint tools.
(*) I didn't blidnly accept all coding style changes from linters,
dropping the ones that would make the final code worse.
Thanks,
Mauro