Re: [PATCH v2] staging: media: atomisp: Replace scnprintf with sysfs_emit in bo_show

[Abdelrahman Fekry]

On Sun, Jun 22, 2025 at 11:52 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Sun, Jun 22, 2025 at 11:42 PM Abdelrahman Fekry
> <abdelrahmanfekry375@xxxxxxxxx> wrote:
> > On Sun, Jun 22, 2025 at 23:39 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> >> On Sun, Jun 22, 2025 at 11:37 PM Andy Shevchenko
> >> <andy.shevchenko@xxxxxxxxx> wrote:
> >> > On Sun, Jun 22, 2025 at 9:54 AM Abdelrahman Fekry
> >> > <abdelrahmanfekry375@xxxxxxxxx> wrote:


> First of all, it's a bare minimum, which means that you should go
> deeper into the code to understand the issue to begin with. Second,
> the comment should be put in the proper place. In the code it's
> useless as it describes something that is absent in the code for odd
> reasons. Talk to your mentors and ask them for help because explaining
> more is basically doing your job for you. And IIUC the purpose of
> mentoring is to make sure you learn something and have acknowledged
> this in practice.
>
Thanks , i will come back with v3 with more explanation and details.
> --
> With Best Regards,
> Andy Shevchenko