Re: [PATCH v2] staging: media: atomisp: Replace scnprintf with sysfs_emit in bo_show
From: Abdelrahman Fekry
Date: Sun Jun 22 2025 - 16:46:27 EST
On Sun, Jun 22, 2025 at 11:39 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Sun, Jun 22, 2025 at 11:37 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Sun, Jun 22, 2025 at 9:54 AM Abdelrahman Fekry
> > <abdelrahmanfekry375@xxxxxxxxx> wrote:
>
> ...
>
> > > + /* Changing to sysfs_emit changes the behaviour if failed*/
> >
> > This comment, besides missing the space, is useless here. You need to
> > use the comment block for the proposed change.
>
> Also the text of the comment is a noise. You need to explain better
> what's going on here.
>
Sorry for the mess, so the comment is enough if well written or i
should do something else?
Thanks!
> --
> With Best Regards,
> Andy Shevchenko