Re: [PATCH v2] staging: media: atomisp: Replace scnprintf with sysfs_emit in bo_show
From: Andy Shevchenko
Date: Sun Jun 22 2025 - 16:38:50 EST
On Sun, Jun 22, 2025 at 9:54 AM Abdelrahman Fekry
<abdelrahmanfekry375@xxxxxxxxx> wrote:
>
> Convert buffer output to use sysfs_emit/sysfs_emit_at API for safer
> PAGE_SIZE handling and standardized sysfs output.
...
> + /* Changing to sysfs_emit changes the behaviour if failed*/
This comment, besides missing the space, is useless here. You need to
use the comment block for the proposed change.
> + offset += sysfs_emit(buf, "type pgnr\n");
--
With Best Regards,
Andy Shevchenko