Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

[Andrew Morton]

On Fri, 20 Jun 2025 17:53:15 +0100 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:

> On Fri, Jun 20, 2025 at 03:34:47PM +0100, Matthew Wilcox (Oracle) wrote:
> > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping,
> > +		pgoff_t index, fgf_t fgp_flags, gfp_t gfp,
> > +		struct mempolicy *policy)
> >  {
> >  	struct folio *folio;
> >  
> > @@ -1982,7 +1984,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index,
> >  			err = -ENOMEM;
> >  			if (order > min_order)
> >  				alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN;
> > -			folio = filemap_alloc_folio(alloc_gfp, order, NULL);
> > +			folio = filemap_alloc_folio(alloc_gfp, order, policy);
> >  			if (!folio)
> >  				continue;
> 
> This is missing the EXPORT_SYMBOL_GPL() change

I added this:

--- a/mm/filemap.c~filemap-add-__filemap_get_folio_mpol-fix
+++ a/mm/filemap.c
@@ -2032,7 +2032,7 @@ no_page:
 		folio_clear_dropbehind(folio);
 	return folio;
 }
-EXPORT_SYMBOL(__filemap_get_folio);
+EXPORT_SYMBOL(__filemap_get_folio_mpol);
 
 static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max,
 		xa_mark_t mark)
_