Re: [PATCH 1/3] i3c: master: Add inline i3c_master_readsl and i3c_master_writesl

From: Jorge Marques
Date: Sun Jun 22 2025 - 04:31:30 EST


On Fri, Jun 20, 2025 at 11:15:09PM +0200, Wolfram Sang wrote:
> On Fri, Jun 20, 2025 at 06:54:59PM +0200, Jorge Marques wrote:
> > The i3c abstraction excepts u8 buffers, but some controllers have a bus
> > width of 32-bits and don't support flagging valid bytes, so it is
> > required to read/write long words and to use memcpy on the remainder of
> > the number of bytes by 32-bits to not write/read outside the buffer
> > bounds.
> >
> > Signed-off-by: Jorge Marques <jorge.marques@xxxxxxxxxx>
>
> Suggested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> > + * i3c_master_writesl- Write bytes to long memory region from byte array
>
Hi Wolfram,
> Frank proposed the name 'i3c_writel_fifo' which I like a tad better.
> Opinions?
>
I don't oppose the change and I'll rename, as well moving the method to
internals.h

i3c_master_writesl -> i3c_writel_fifo
i3c_master_readsl -> i3c_readl_fifo

Best Regards,
Jorge