Re: [PATCH v3 2/2] iio: temperature: add support for MCP998X
From: Jonathan Cameron
Date: Sat Jun 21 2025 - 13:20:41 EST
On Thu, 19 Jun 2025 11:29:30 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Jun 19, 2025 at 10:22 AM <Victor.Duicu@xxxxxxxxxxxxx> wrote:
> > On Sat, 2025-06-14 at 00:50 +0300, Andy Shevchenko wrote:
> > > On Fri, Jun 13, 2025 at 4:02 PM <victor.duicu@xxxxxxxxxxxxx> wrote:
>
> ...
>
> > > > +MICROCHIP MCP9982 TEMPERATURE DRIVER
> > > > +M: Victor Duicu <victor.duicu@xxxxxxxxxxxxx>
> > > > +L: linux-iio@xxxxxxxxxxxxxxx
> > > > +S: Supported
> > > > +F:
> > > > Documentation/devicetree/bindings/iio/temperature/microchip,mcp9982
> > > > .yaml
> > > > +F: drivers/iio/temperature/mcp9982.c
> > >
> > > So, with the first patch only the dangling file will be present
> > > without record in MAINTAINERS. Please, make sure that your DT schema
> > > file is in MAINTAINERS.
> >
> > Are you referring here to the file sysfs-bus-iio-temperature-mcp9982?
> > This file was in v2 where there were a few custom attributes. In v3
> > I removed them, so the driver currently doesn't have custom attributes.
> > Should I had added it to the files in MAINTAINERS?
>
> You should have added the file to the MAINTAINERS in the same patch it
> appears. Not in some arbitrary change afterwards.
>
Perhaps the confusion here is that Andy is talking about 2 lines above, not
the immediate line above this feedback. So the one with the dt-binding
file. If Victor was reading it as being about the .c file then
this whole cross discussion makes more sense!
Jonathan