Re: [GIT PULL] smb3 client fixes

From: Steve French
Date: Sat Jun 21 2025 - 12:00:34 EST


I can remove that and resend, handling special files properly can be
important (and there is a much more important patch being reviewed for
fixing some symlink corner cases) but SMB1 is much lower priority.

On Sat, Jun 21, 2025 at 10:55 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, 20 Jun 2025 at 15:57, Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > - Fix reparse points (special file handling) for SMB1
>
> I'm not seeing this being a fix at all. This seems to be entirely new
> functionality, with not even a whiff of "this fixes Xyz".
>
> I pulled and then unpulled again. Because WTF?
>
> If it's a real fix for a real problem, it needs to be explained as such.
>
> And if it is what it looks like and the explanation says it is, then
> it damn well shouldn't be hidden in a "fixes" pull and tried to be
> sneaked in with the pull request dressing it up as anything else.
>
> Linus



--
Thanks,

Steve