Re: [PATCH v1 03/55] media: i2c: ar0521: Use the v4l2 helper for obtaining the clock

[Krzysztof Hałasa | Łukasiewicz – PIAP]

Hi Mehdi,

I guess it's the same as all other patches in the series.

Sorry if the message formatting is weird - I'm a bit offline now.

> devm_clk_get() fails on ACPI-based platforms, where firmware does not
> provide a direct reference to the clock producer.

> Replace devm_clk_get() with the new v4l2 helper devm_v4l2_sensor_clk_get()
> that works on both DT- and ACPI-based platforms to retrieve a reference to
> the clock producer from firmware.

> Signed-off-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxxxxxx>

Acked-By: Krzysztof Hałasa <khalasa@xxxxxxx>

--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -1077,7 +1077,7 @@ static int ar0521_probe(struct i2c_client *client)
        }

        /* Get master clock (extclk) */
-       sensor->extclk = devm_clk_get(dev, "extclk");
+       sensor->extclk = devm_v4l2_sensor_clk_get(dev, "extclk");
        if (IS_ERR(sensor->extclk)) {
                dev_err(dev, "failed to get extclk\n");
                return PTR_ERR(sensor->extclk);