Re: [PATCH 03/11] power: supply: qcom_pmi8998_charger: fix wakeirq
From: Dmitry Baryshkov
Date: Fri Jun 20 2025 - 17:44:54 EST
On Thu, Jun 19, 2025 at 04:55:11PM +0200, Casey Connolly wrote:
> Unloading and reloading the driver (e.g. when built as a module)
> currently leads to errors trying to enable wake IRQ since it's already
> enabled.
>
> Use devm to manage this for us so it correctly gets disabled when
> removing the driver.
>
> Additionally, call device_init_wakeup() so that charger attach/remove
> will trigger a wakeup by default.
>
> Fixes: 8648aeb5d7b7 ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver")
> Signed-off-by: Casey Connolly <casey.connolly@xxxxxxxxxx>
> ---
> drivers/power/supply/qcom_pmi8998_charger.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry