Re: [PATCH v2 00/17] SHA-512 library functions

[Eric Biggers]

On Sun, Jun 15, 2025 at 06:40:02PM -0700, Eric Biggers wrote:
> This series applies to v6.16-rc1 and is targeting the libcrypto-next
> tree.  It is also available at:
> 
>     git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git sha512-lib-v2
> 
> This series adds support for SHA-384, SHA-512, HMAC-SHA384, and
> HMAC-SHA512 to lib/crypto/.  The new functions take advantage of the
> kernel's existing architecture-optimized implementations of the SHA-512
> compression function.  The new functions are fully tested using KUnit.

FYI, applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

Additional reviews and acks would be greatly appreciated, though!

As per Linus's request, I reordered the KUnit tests (patches 4-5) to be last.
I'll try to keep them last as additional non-test patches get applied.

I also adjusted commit titles slightly to match what I'm planning to use for
lib/crypto and lib/crc going forwards:
    
        lib/(crypto|crc): ((algorithm|arch|arch/algorithm):)? Subject

    e.g.

        lib/crypto: sha512: Add KUnit tests for SHA-384 and SHA-512
        lib/crypto: x86: Move arch/x86/lib/crypto/ into lib/crypto/
        lib/crypto: x86/sha512: Migrate optimized SHA-512 code to library
        lib/crypto: Explicitly include <linux/export.h>

- Eric