Re: [PATCH RFC 15/29] mm/migration: remove PageMovable()

From: Zi Yan
Date: Fri Jun 20 2025 - 16:19:35 EST


On 18 Jun 2025, at 13:39, David Hildenbrand wrote:

> As __ClearPageMovable() is gone that would have only made
> PageMovable()==false but still __PageMovable()==true, now
> PageMovable() == __PageMovable().
>
> So we can replace PageMovable() checks by __PageMovable(). In fact,
> __PageMovable() cannot change until a page is freed, so we can turn
> some PageMovable() into sanity checks for __PageMovable().
>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
> include/linux/migrate.h | 2 --
> mm/compaction.c | 15 ---------------
> mm/migrate.c | 18 ++++++++++--------
> 3 files changed, 10 insertions(+), 25 deletions(-)
>
Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>

--
Best Regards,
Yan, Zi