Re: [PATCHv6 04/16] x86/efi: Move runtime service initialization to arch/x86

From: Kirill A. Shutemov
Date: Fri Jun 20 2025 - 13:43:34 EST


On Fri, Jun 20, 2025 at 08:35:14AM -0700, Dave Hansen wrote:
> On 6/20/25 06:53, Kirill A. Shutemov wrote:
> > From: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> >
> > The EFI call in start_kernel() is guarded by #ifdef CONFIG_X86. Move
> > the thing to the arch_cpu_finalize_init() path on x86 and get rid of
> > the #ifdef in start_kernel().
>
> What does this have to do with LASS?

It is required to move CR pinning below it and allow to disable CR4.LASS
temporarily during EFI initialization.

> Is there any reason not to just pull this in to tip now as a cleanup? It
> looks good regardless of what it does to LASS.

I am totally fine with applying it right away.

--
Kiryl Shutsemau / Kirill A. Shutemov