Re: [PATCH v3 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw in S2Idle/S3 resume

[Nilawar, Badal]

On 20-06-2025 19:19, Rodrigo Vivi wrote:
> On Thu, Jun 19, 2025 at 12:30:04AM +0530, Badal Nilawar wrote:
> > Reload late binding fw during S2Idle/S3 resume.
> >
> > Signed-off-by: Badal Nilawar <badal.nilawar@xxxxxxxxx>
> > ---
> >   drivers/gpu/drm/xe/xe_pm.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> > index 91923fd4af80..6c44a075a6ab 100644
> > --- a/drivers/gpu/drm/xe/xe_pm.c
> > +++ b/drivers/gpu/drm/xe/xe_pm.c
> > @@ -205,6 +205,9 @@ int xe_pm_resume(struct xe_device *xe)
> >   
> >   	xe_pxp_pm_resume(xe->pxp);
> >   
> > +	if (xe->d3cold.allowed)
> > +		xe_late_bind_fw_load(&xe->late_bind);
> something seems off here... d3cold allowed should only be used
> for the runtime pm portion from the cases we can lose power like d3cold.
> But we don't use that in the s3 path.
>
> We should probably have 2 different calls here. unconditionally call
> in the regular/system suspend path and conditionally call in the runtime one.

Agree, we should unconditionally reload lb binary in regular 
suspend/resume path. I will remove D3Cold check.

Regards,
Badal

> > +
> >   	drm_dbg(&xe->drm, "Device resumed\n");
> >   	return 0;
> >   err:
> > --
> > 2.34.1