Re: [PATCH] pinctrl: zynq: add CONFIG_OF dependency

From: Bartosz Golaszewski
Date: Fri Jun 20 2025 - 10:39:29 EST


On Fri, Jun 20, 2025 at 3:46 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Fri, Jun 20, 2025, at 15:36, Bartosz Golaszewski wrote:
> > On Fri, Jun 20, 2025 at 3:08 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> >> --- a/drivers/pinctrl/Kconfig
> >> +++ b/drivers/pinctrl/Kconfig
> >> @@ -603,6 +603,7 @@ config PINCTRL_TH1520
> >> config PINCTRL_ZYNQ
> >> bool "Pinctrl driver for Xilinx Zynq"
> >> depends on ARCH_ZYNQ || COMPILE_TEST
> >> + depends on OF
> >> select PINMUX
>
> >
> > I don't think this is the actual problem. I can build (and link)
> > pinctrl-zynq with COMPILE_OF disabled alright. Can you paste the
> > entire offending .config somewhere?
>
> This is from a randconfig build: https://pastebin.com/ism57RPe
>
> Arnd

Right. I don't have the time to look into untangling it but in general
all OF interfaces have relevant stubs so `depends on OF` should not be
needed. But it's more complex here in pinctrl so I'm fine with this
for now.

Bartosz