Re: [PATCH v2 1/5] block: sanitize chunk_sectors for atomic write limits
From: Nilay Shroff
Date: Fri Jun 20 2025 - 10:31:29 EST
On 6/18/25 2:07 PM, John Garry wrote:
> Currently we just ensure that a non-zero value in chunk_sectors aligns
> with any atomic write boundary, as the blk boundary functionality uses
> both these values.
>
> However it is also improper to have atomic write unit max > chunk_sectors
> (for non-zero chunk_sectors), as this would lead to splitting of atomic
> write bios (which is disallowed).
>
> Sanitize atomic write unit max against chunk_sectors to avoid any
> potential problems.
>
> Fixes: d00eea91deaf3 ("block: Add extra checks in blk_validate_atomic_write_limits()")
> Signed-off-by: John Garry <john.g.garry@xxxxxxxxxx>
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@xxxxxxxxxxxxx>