Re: [PATCH] regulator: tps65219: Fix devm_kmalloc size allocation

From: Robert Nelson
Date: Fri Jun 20 2025 - 09:31:20 EST


On Thu, Jun 19, 2025 at 7:09 PM Shree Ramamoorthy <s-ramamoorthy@xxxxxx> wrote:
>
> In probe(), devm_kmalloc uses pmic->common_irq_size to allocate an array of
> 2 bytes, but pmic->common_irq_size is being used like an array of structs.
> The param sent should've been pmic->common_irq_size * sizeof(*irq_data).
> This led to an issue with the kmalloc'd buffer being corrupted and EVM boot
> issues. The common and device-specific structs are now allocated one at a
> time within the loop.
>
> Fixes: 38c9f98db20a ("regulator: tps65219: Add support for TPS65215 Regulator IRQs")
> Reported-by: Dhruva Gole <d-gole@xxxxxx>
> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@xxxxxx>

Thanks Shree! Starting testing on PB2/BeaglePlay's..


> base-commit: 5c8013ae2e86ec36b07500ba4cacb14ab4d6f728
> prerequisite-patch-id: cd76c901948780de20e932cf620806959e2177b1
> prerequisite-patch-id: e847098a38d07e5ff31e8c80d86d9702d132fdad
> prerequisite-patch-id: e6a01f111e527c6da442f6756f8daa4e79d0fa3c

ps, worked around these 3 missing in v6.16-rc2, which git tree do you
have them staged?

Regards,

--
Robert Nelson
https://rcn-ee.com/