RE: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS field definitions to igc_defines.h

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf
> Of Song Yoong Siang
> Sent: Friday, June 20, 2025 12:03 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Richard
> Cochran <richardcochran@xxxxxxxxx>; Alexei Starovoitov
> <ast@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; Jesper
> Dangaard Brouer <hawk@xxxxxxxxxx>; John Fastabend
> <john.fastabend@xxxxxxxxx>; Gomes, Vinicius
> <vinicius.gomes@xxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Shinas Rasheed
> <srasheed@xxxxxxxxxxx>; Tian, Kevin <kevin.tian@xxxxxxxxx>; Brett
> Creeley <brett.creeley@xxxxxxx>; Blanco Alcaine, Hector
> <hector.blanco.alcaine@xxxxxxxxx>; Hay, Joshua A
> <joshua.a.hay@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; Keller,
> Jacob E <jacob.e.keller@xxxxxxxxx>; Kurt Kanzenbach
> <kurt@xxxxxxxxxxxxx>; Marcin Szycik <marcin.szycik@xxxxxxxxxxxxxxx>;
> Brett Creeley <bcreeley@xxxxxxx>
> Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH iwl-next, v3 1/2] igc: Relocate RSS
> field definitions to igc_defines.h
> 
> Move the RSS field definitions related to IPv4 and IPv6 UDP from igc.h
> to igc_defines.h to consolidate the RSS field definitions in a single
> header file, improving code organization and maintainability.
> 
> This refactoring does not alter the functionality of the driver but
> enhances the logical grouping of related constants
> 
> Reviewed-by: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>
> Signed-off-by: Song Yoong Siang <yoong.siang.song@xxxxxxxxx>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/igc/igc.h         | 4 ----
>  drivers/net/ethernet/intel/igc/igc_defines.h | 3 +++
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc.h
> b/drivers/net/ethernet/intel/igc/igc.h
> index 1525ae25fd3e..0b35e593d5ee 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -406,10 +406,6 @@ extern char igc_driver_name[];
>  #define IGC_FLAG_RSS_FIELD_IPV4_UDP	BIT(6)
>  #define IGC_FLAG_RSS_FIELD_IPV6_UDP	BIT(7)
> 
> -#define IGC_MRQC_ENABLE_RSS_MQ		0x00000002
> -#define IGC_MRQC_RSS_FIELD_IPV4_UDP	0x00400000
> -#define IGC_MRQC_RSS_FIELD_IPV6_UDP	0x00800000
> -
>  /* RX-desc Write-Back format RSS Type's */  enum igc_rss_type_num {
>  	IGC_RSS_TYPE_NO_HASH		= 0,
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h
> b/drivers/net/ethernet/intel/igc/igc_defines.h
> index 86b346687196..d80254f2a278 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -383,11 +383,14 @@
>  #define IGC_RXDEXT_STATERR_IPE		0x40000000
>  #define IGC_RXDEXT_STATERR_RXE		0x80000000
> 
> +#define IGC_MRQC_ENABLE_RSS_MQ		0x00000002
>  #define IGC_MRQC_RSS_FIELD_IPV4_TCP	0x00010000
>  #define IGC_MRQC_RSS_FIELD_IPV4		0x00020000
>  #define IGC_MRQC_RSS_FIELD_IPV6_TCP_EX	0x00040000
>  #define IGC_MRQC_RSS_FIELD_IPV6		0x00100000
>  #define IGC_MRQC_RSS_FIELD_IPV6_TCP	0x00200000
> +#define IGC_MRQC_RSS_FIELD_IPV4_UDP	0x00400000
> +#define IGC_MRQC_RSS_FIELD_IPV6_UDP	0x00800000
> 
>  /* Header split receive */
>  #define IGC_RFCTL_IPV6_EX_DIS	0x00010000
> --
> 2.34.1