Re: [PATCH 3/3] kunit: test: Drop CONFIG_MODULE ifdeffery

[David Gow]

On Thu, 12 Jun 2025 at 22:54, Thomas Weißschuh
<thomas.weissschuh@xxxxxxxxxxxxx> wrote:
>
> The function stubs exposed by module.h allow the code to compile properly
> without the ifdeffery. The generated object code stays the same, as the
> compiler can optimize away all the dead code.
> As the code is still typechecked developer errors can be detected faster.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---

Acked-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David


>  lib/kunit/test.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> index 146d1b48a0965e8aaddb6162928f408bbb542645..019b2ac9c8469021542b610278f8842e100d57ad 100644
> --- a/lib/kunit/test.c
> +++ b/lib/kunit/test.c
> @@ -759,7 +759,6 @@ void __kunit_test_suites_exit(struct kunit_suite **suites, int num_suites)
>  }
>  EXPORT_SYMBOL_GPL(__kunit_test_suites_exit);
>
> -#ifdef CONFIG_MODULES
>  static void kunit_module_init(struct module *mod)
>  {
>         struct kunit_suite_set suite_set, filtered_set;
> @@ -847,7 +846,6 @@ static struct notifier_block kunit_mod_nb = {
>         .notifier_call = kunit_module_notify,
>         .priority = 0,
>  };
> -#endif
>
>  KUNIT_DEFINE_ACTION_WRAPPER(kfree_action_wrapper, kfree, const void *)
>
> @@ -938,20 +936,14 @@ static int __init kunit_init(void)
>         kunit_debugfs_init();
>
>         kunit_bus_init();
> -#ifdef CONFIG_MODULES
>         return register_module_notifier(&kunit_mod_nb);
> -#else
> -       return 0;
> -#endif
>  }
>  late_initcall(kunit_init);
>
>  static void __exit kunit_exit(void)
>  {
>         memset(&kunit_hooks, 0, sizeof(kunit_hooks));
> -#ifdef CONFIG_MODULES
>         unregister_module_notifier(&kunit_mod_nb);
> -#endif
>
>         kunit_bus_shutdown();
>
>
> --
> 2.49.0
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature