Re: [PATCH v2 2/3] dt-bindings: arm: imx8mp: Add Ultratronik Ultra-MACH SBC

[Goran Radenovic]

Krzysztof Kozlowski wrote:
> On 12/06/2025 12:09, Goran Radenovic wrote:
> > Hi Krzysztof,
> >
> > Thanks for the feedback, and you're absolutely right — I made a mistake
> > here.
> >
> > That said, I’m still a bit confused by your earlier comment:
> >
> >       "That's just part of the standard/first enum."
> >
> > I’m introducing a new board from a new manufacturer, so I expected to
> > add a new enum block — similar to how it's done for other vendor entries
>
> No, you are expected to add to existing enum.

Very well, I'll add the entry to the existing `description: i.MX8MP 
based Boards` block.

> > in the same file. I ran dt_binding_check, and it passed without errors
> > for this structure.
>
> Not possible. The syntax is clearly wrong, so there is no way it passed
> any tests. And Rob's report is a proof of that.

You are right for v2. I was referring to v1. Sorry for the confusion.

> > Could you clarify which “standard/first enum” you were referring to?
> > Should all i.MX8MP-based boards share a single enum block, regardless of
> > vendor?
>
> Don't they? Look around in this file.

I did, and I've learned something.

> > Thanks again for your guidance.
>
> Don't top post but reply inline.

Ok, thank you for the correction.

> Best regards,
> Krzysztof


Best regards
Goran