Re: [RFC PATCH 1/3] media: dt-bindings: Add regulator current load

[Krzysztof Kozlowski]

On 20/06/2025 06:07, Wenmeng Liu wrote:
> Add regulator current load support for vdda-phy vdda-pll.
> 
> Signed-off-by: Wenmeng Liu <quic_wenmliu@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/media/qcom,sc7280-camss.yaml        | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

This patch fails on so many levels... do internal reviews first.

Use existing properties, see regulators. If not, use existing unit
suffixes. Otherwise it is just another downstream property you send us,
to which we responded many times - don't.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Read meeting notes from internal discussions where you discussed this
already.

Best regards,
Krzysztof