RE: [PATCH iwl-next,v2 1/1] igc: Add wildcard rule support to ethtool NFC using Default Queue

[Song, Yoong Siang]

On Thursday, June 19, 2025 11:49 PM, Brett Creeley <bcreeley@xxxxxxx> wrote:
>On 6/19/2025 8:37 AM, Song Yoong Siang wrote:
>> diff --git a/drivers/net/ethernet/intel/igc/igc.h
>b/drivers/net/ethernet/intel/igc/igc.h
>> index 1525ae25fd3e..c580ecc954be 100644
>> --- a/drivers/net/ethernet/intel/igc/igc.h
>> +++ b/drivers/net/ethernet/intel/igc/igc.h
>> @@ -406,10 +406,6 @@ extern char igc_driver_name[];
>>   #define IGC_FLAG_RSS_FIELD_IPV4_UDP    BIT(6)
>>   #define IGC_FLAG_RSS_FIELD_IPV6_UDP    BIT(7)
>>
>> -#define IGC_MRQC_ENABLE_RSS_MQ         0x00000002
>> -#define IGC_MRQC_RSS_FIELD_IPV4_UDP    0x00400000
>> -#define IGC_MRQC_RSS_FIELD_IPV6_UDP    0x00800000
>> -
>
>Small nit, but moving these fields seems like a separate patch since
>moving them isn't part of the wildcard rule changes.
>
>Thanks,
>
>Brett

Hi Brett,

Thanks for reviewing the patch.
No problem, I can split the patch into two and submit v3.

Thanks & Regards
Siang