Re: [PATCH v4] ARM: dts: aspeed: yosemite4: add gpio name for uart mux sel

From: Andrew Jeffery
Date: Fri Jun 20 2025 - 03:27:38 EST


Hi Marshall,

On Wed, 2025-06-18 at 15:08 +0800, MarshallZhan-wiwynn wrote:
> Add gpio line name to support multiplexed console
>
> Signed-off-by: Marshall Zhan <marshall_zhan@xxxxxxxxxx>

Thanks for fixing the email situation. However, I notice your git
username is set to `MashallZhan-wiwynn`, which is different how you've
filled out the Signed-off-by tag. I'd prefer you make them consistent.
You can do this with:

git config --global user.name "Marshall Zhan"

Some people choose to include their employer like you have. Typically
this is done like:

git config --global user.name "Marshall Zhan (Wiwynn)"

The patch is fine otherwise.

Thanks,

Andrew