Re: [PATCH v4 1/2] dt-bindings: net: bluetooth: nxp: Add support for 4M baudrate

From: Krzysztof Kozlowski
Date: Fri Jun 20 2025 - 03:17:48 EST


On Thu, Jun 19, 2025 at 04:46:28PM GMT, Neeraj Sanjay Kale wrote:
> Add support for 4000000 as secondary baudrate.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx>
> ---
> v2: Use the available 'max-speed' device tree property. (Krzysztof)
> v3: No Change
> v4: Add ref for max-speed. (Krzysztof)

No, why?

> ---
> .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 3ab60c70286f..bb9ab5dd3b4a 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -34,6 +34,13 @@ properties:
> This property depends on the module vendor's
> configuration.
>
> + max-speed:
> + $ref: /schemas/types.yaml#/definitions/uint32

No, drop, I did not ask that.

I asked to do like other bindings, just look at them. I gave you exact
ref which is missing.

NAK

Best regards,
Krzysztof