Re: [RFC 1/2] lib/vsprintf: Add support for pte_t

[Anshuman Khandual]

On 19/06/25 6:42 PM, Petr Mladek wrote:
> On Wed 2025-06-18 20:46:38, Andy Shevchenko wrote:
>> On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote:
>>> Add a new format for printing page table entries.
>>
>>> Cc: Petr Mladek <pmladek@xxxxxxxx>
>>> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
>>> Cc: Jonathan Corbet <corbet@xxxxxxx>
>>> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>>> Cc: David Hildenbrand <david@xxxxxxxxxx>
>>> Cc: linux-doc@xxxxxxxxxxxxxxx
>>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>>> Cc: linux-mm@xxxxxxxxx
>>
>> Please. move these to be after the '---' cutter line below. Just leave SoB tag
>> alone. This will have the same effect w/o polluting commit message.
>>
>>> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
>>> ---
>>
>> (somewhere here is a good place for all your Cc: tags)
>>
>> ...
>>
>>> +        %ppte
>>
>> I believe you can take %pte.
> 
> We should think about the future. If we added "pte", people would want
> to add also "pmd", "pud", ...
> 
> It might actually be a good idea to keep them under the %pp prefix.

Agreed.

The first 'p' here is for being pointer and second 'p' is from 'p'xx.
Then last two letters to differentiate between page table levels.