Re: [PATCH 2/3] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>

[Binbin Wu]

On 6/20/2025 10:57 AM, Binbin Wu wrote:
> On 6/20/2025 2:01 AM, Paolo Bonzini wrote:
> [...]
> > @@ -7174,6 +7175,52 @@ The valid value for 'flags' is:
> >     - KVM_NOTIFY_CONTEXT_INVALID -- the VM context is corrupted and not valid
> >       in VMCS. It would run into unknown result if resume the target VM.
> >   +::
> > +
> > +        /* KVM_EXIT_TDX */
> > +        struct {
> > +            __u64 flags;
> > +            __u64 nr;
> > +            union {
> > +                struct {
> > +                    u64 ret;
> > +                    u64 data[5];
> Should the interface reserve more elements?
>
> Without considering XMM registers, the possible registers according to GHCI spec
> are RBX, RDX, RBP, RDI, RSI, R8, R9, R12-R15. Since RBP is not suggested to be
> used to pass information, how about make the array 10 elements?

Please Ignore it, there is no need to do this.

> > +                } unknown;
> > +                struct {
> > +                    u64 ret;
> > +                    u64 gpa;
> > +                    u64 size;
> > +                } get_quote;
> > +            };
> > +        } tdx;
> > +