Re: [PATCH] PCI/pwrctrl: Skip creating platform device unless CONFIG_PCI_PWRCTL enabled

From: Florian Fainelli
Date: Thu Jun 19 2025 - 20:06:15 EST


On 5/27/25 15:25, 'Bjorn Helgaas' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
On Sat, May 24, 2025 at 02:21:04PM +0530, Manivannan Sadhasivam wrote:
On Sat, May 24, 2025 at 08:29:46AM +0200, Lukas Wunner wrote:
On Fri, May 23, 2025 at 09:42:07PM -0500, Bjorn Helgaas wrote:
What I would prefer is something like the first paragraph in that
section: the #ifdef in a header file that declares the function and
defines a no-op stub, with the implementation in some pwrctrl file.

pci_pwrctrl_create_device() is static, but it is possible to #ifdef
the whole function in the .c file and provide the stub in an #else
branch. That's easier to follow than #ifdef'ing portions of the
function.


+1

I dropped the ball here and didn't get any fix for this in v6.15.

Any chance we could target a fix to be back ported into 6.15 stable? Do you need people to help you test it?
--
Florian