Re: [PATCH v7 02/10] x86/fred: Pass event data to the NMI entry point from KVM

From: Sohil Mehta
Date: Thu Jun 19 2025 - 18:58:17 EST


On 6/19/2025 3:45 PM, Xin Li wrote:
> On 6/19/2025 3:15 PM, Sohil Mehta wrote:
>>
>> I want to say that the event data for IRQ has to be zero until the
>> architecture changes — Similar to the /* Reserved, must be 0 */ comment
>> in asm_fred_entry_from_kvm().
>>
>
> FRED spec says:
>
> For any other event, the event data are not currently defined and will
> be zero until they are.
>
> So "Event data not defined for IRQ thus 0."

I am fine with this. Not *defined* removes the ambiguity.